Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refine replace into by caching individual BlockMeta #17368

Merged
merged 1 commit into from
Feb 6, 2025
Merged

refactor: refine replace into by caching individual BlockMeta #17368

merged 1 commit into from
Feb 6, 2025
+51 −20

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Jan 25, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refine replace into by caching individual BlockMeta

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - refactor, use existing test cases

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Jan 25, 2025
@dantengsky dantengsky marked this pull request as ready for review February 5, 2025 02:06
@dantengsky dantengsky added this pull request to the merge queue Feb 6, 2025
Merged via the queue into databendlabs:main with commit c5c7fce Feb 6, 2025
76 checks passed
@dantengsky dantengsky deleted the refact/refine-replace-into branch February 6, 2025 04:15
@dantengsky dantengsky mentioned this pull request Feb 6, 2025
Draft
11 tasks
dantengsky added a commit to dantengsky/fuse-query that referenced this pull request Feb 6, 2025
@dantengsky
refactor: refine replace into by caching individual BlockMeta (data…
9f2a20b 
…bendlabs#17368)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhyass zhyass zhyass approved these changes

@SkyFan2002 SkyFan2002 Awaiting requested review from SkyFan2002

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantengsky @zhyass